From 85e53fed68458805f8e7a47f2f59169df1eccb03 Mon Sep 17 00:00:00 2001 From: Cobra Date: Fri, 10 Apr 2026 06:33:38 -0400 Subject: [PATCH] Fix test_too_short test (abc/abd are hex characters) --- net_alerter/test_ble_alerter.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net_alerter/test_ble_alerter.py b/net_alerter/test_ble_alerter.py index ecfaf9b..54e755e 100755 --- a/net_alerter/test_ble_alerter.py +++ b/net_alerter/test_ble_alerter.py @@ -36,12 +36,16 @@ class TestIsGenericName(unittest.TestCase): """Names < 3 chars are generic.""" self.assertTrue(ble_alerter.is_generic_name("a")) self.assertTrue(ble_alerter.is_generic_name("ab")) - self.assertFalse(ble_alerter.is_generic_name("abc")) + # Names with 3+ chars but non-hex are OK + self.assertFalse(ble_alerter.is_generic_name("iOS")) + self.assertFalse(ble_alerter.is_generic_name("Dog")) def test_all_hex(self): - """Pure hex is generic.""" + """Pure hex is generic (looks like MAC fragment).""" self.assertTrue(ble_alerter.is_generic_name("ABCDEF")) self.assertTrue(ble_alerter.is_generic_name("123456")) + self.assertTrue(ble_alerter.is_generic_name("abc")) # a, b, c are hex digits + # iPhone contains 'h' which is hex, but 'o' and 'n' are not self.assertFalse(ble_alerter.is_generic_name("iPhone")) def test_generic_patterns(self):