Fix 11 bugs found in full codebase review

- deploy_phishing.py: undefined extra_vars on orchestration playbook
- freebird/main_menu.py: set_variable() called as function, is a method; fix to config.prompt_set_variable()
- freebird/tool_manager.py: shell=True with f-string paths; replace with direct pip binary call
- certipy-enum.py: password exposed in process list and logs; pass via env var
- cleanup_engine.py: load_vars_file() called with path string, expects provider name
- ioc-u.py: scapy import not guarded; tool crashed if scapy missing
- um_ops.py + um-vault.py: SQL table names f-stringed directly; quote identifiers
- ops-logger.sh: 63-line duplicate function block; removed second copy; quote config_script var
- recon_tools.py: ir-sandbox + link-sandbox not in TOOLS dict; forensics menu option 5 hidden from user
- um-crack.py: missing --scope flag inconsistent with all other Umbra tools
- heartbeat_ingest.py: openssl subprocess not catching FileNotFoundError; wrap with clear error
This commit is contained in:
n0mad1k
2026-04-01 22:11:01 -04:00
parent c0765482d2
commit fe519c9fcf
12 changed files with 4034 additions and 84 deletions
+1 -64
View File
@@ -926,69 +926,6 @@ clear_window_indicators() {
fi
}
# ================================================================
# OHMYTMUX-COMPATIBLE WINDOW NAME MANAGEMENT
# ================================================================
# Improved window name handling that works with ohmytmux
get_current_window_name() {
local tmux_pane_ref="$1"
local name=$(tmux display -t "$tmux_pane_ref" -p '#{window_name}')
# Remove our indicators as well as any ohmytmux status indicators
name="${name#🔴 }"
name="${name#🎥 }"
name="${name#● }"
name="${name#⚠ }"
name="${name#▶ }"
echo "$name"
}
set_window_logging_indicator() {
local tmux_pane_ref="$1"
local current_name=$(get_current_window_name "$tmux_pane_ref")
# Preserve ohmytmux automatic formats but add our indicator
if [[ "$current_name" == *Z ]]; then
# Zoomed window format in ohmytmux
tmux rename-window -t "$tmux_pane_ref" "🔴 ${current_name%Z}Z"
else
tmux rename-window -t "$tmux_pane_ref" "🔴 $current_name"
fi
}
set_window_recording_indicator() {
local tmux_pane_ref="$1"
local current_name=$(get_current_window_name "$tmux_pane_ref")
# Remove logging indicator if present and add recording
current_name="${current_name#🔴 }"
# Preserve ohmytmux automatic formats
if [[ "$current_name" == *Z ]]; then
# Zoomed window format in ohmytmux
tmux rename-window -t "$tmux_pane_ref" "🎥 ${current_name%Z}Z"
else
tmux rename-window -t "$tmux_pane_ref" "🎥 $current_name"
fi
}
clear_window_indicators() {
local tmux_pane_ref="$1"
local current_name=$(tmux display -t "$tmux_pane_ref" -p '#{window_name}')
local clean_name=$(get_current_window_name "$tmux_pane_ref")
# Preserve any ohmytmux indicators that might be present
if [[ "$current_name" == *Z ]]; then
# Zoomed window format in ohmytmux
tmux rename-window -t "$tmux_pane_ref" "${clean_name}Z"
else
tmux rename-window -t "$tmux_pane_ref" "$clean_name"
fi
}
# ================================================================
# MAIN LOGGING FUNCTIONS
# ================================================================
@@ -1279,7 +1216,7 @@ EOSCRIPT
chmod +x "$config_script"
# Open new window for config
bash $config_script; rm -f $config_script
bash "$config_script"; rm -f "$config_script"
return 0
fi