Trilltechnician/incredigo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pwstore: keepassxc LIVE-VM proof + root-group entry-path fix

Browse Source 
Proven end-to-end (scan→plan→commit→restore-from-backup) against the real
keepassxc-cli 2.7.6 in the incredigo-sbx sandbox VM. The live run surfaced an
adapter bug the fake CSV masked: KeePassXC's CSV "Group" column is the full path
including the root group name (default root is "Passwords"), but keepassxc-cli
addresses entries relative to root (/GitHub, not /Passwords/GitHub). kpEntryPath
now drops the leading root segment; the unit test that encoded the buggy
/Root/GitHub form is corrected and a nested-group table test added.

Records the proof as data: docs/BROWSER-ROTATION.md promotes keepassxc
MOCK-ONLY -> LIVE-VM (the others stay MOCK-ONLY).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
leetcrypt
2026-06-19 16:57:30 -07:00
parent c2f181e56d
commit 71f1aa4c6f
3 changed files with 46 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/pwstore/keepassxc_test.go
+19 -2
View File
@@ -90,8 +90,10 @@ func TestKeePassXCExport(t *testing.T) {
t.Fatalf("got %d accounts, want 1", len(accts))
}
a := accts[0]
if a.ID != "/Root/GitHub" {
t.Errorf("entry path = %q, want /Root/GitHub", a.ID)
// The root group name ("Root" here) is dropped — keepassxc-cli addresses entries
// relative to the root, so a top-level entry is "/GitHub" not "/Root/GitHub".
if a.ID != "/GitHub" {
t.Errorf("entry path = %q, want /GitHub", a.ID)
}
if a.Username != "alice@example.com" || a.Site != "github.com" {
t.Errorf("account = %+v", a)
@@ -128,6 +130,21 @@ func TestKeePassXCUpdatePassword(t *testing.T) {
}
}
func TestKPEntryPathDropsRootGroup(t *testing.T) {
cases := []struct{ group, title, want string }{
{"Passwords", "GitHub", "/GitHub"}, // root entry: root name dropped
{"Root", "GitHub", "/GitHub"}, // same, different root name
{"", "GitHub", "/GitHub"}, // no group at all
{"Passwords/Web", "GitHub", "/Web/GitHub"}, // nested: keep subgroup, drop root
{"/Passwords/Web/", "GitHub", "/Web/GitHub"}, // surrounding slashes tolerated
}
for _, c := range cases {
if got := kpEntryPath(c.group, c.title); got != c.want {
t.Errorf("kpEntryPath(%q,%q) = %q, want %q", c.group, c.title, got, c.want)
}
}
}
func TestKeePassXCUnavailableWithoutDB(t *testing.T) {
k := &KeePassXC{Bin: "keepassxc-cli"}
if k.Available() {