Replace the overloaded "text + no tool call = done" terminator that made the weak CPU model stall mid-task or give up after a failing command. Termination is now a structural `DONE:` text sentinel; a text-only turn is resolved by an output-aware verdict (DONE: marker / unresolved non-zero exit / no action / filler language) and re-prompted with an exit-code-aware nudge, bounded by MAX_NUDGES on top of max_turns. On exhaustion the summary is honest rather than echoing the model's false "run successfully" — it reports when no tool ran or a command exited non-zero. Live-validated on qwen2.5:3b: the multi-step stall is fixed (proj3 completes end-to-end, ground-truth confirmed); the nudge fires on a 126; residual give-up is model-bound. 23 offline unit assertions pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9.3 KiB
Native harness — live command-entry findings + nudge-loop design
Date: 2026-06-10
Context: Evaluating the native tool-calling harness (cmd_chat/agent/bridge.py,
_run_native) on its ability to drive shell commands into the shared podman/Kali
sandbox, on a CPU-only box (no GPU). Two prior fixes were live-validated here and
committed in a0aa14d: §3 PTY-sentinel (_run_shell_in_pty) and NATIVE_CONTEXT=4.
Test setup
- Fresh room, podman sandbox (
hack-housecontainer),/grant aidrive. - Models compared:
qwen2.5:3b(1.9 GB, prior default) andqwen2.5-coder:7b(4.7 GB, pulled for this test).deepseek-r1:latestandwestenfelder/NL2SHwere ruled out — both reject Ollama'stoolsfield (HTTP 400 "does not support tools"), so they degrade to the simple injector and can't exercise the native loop. - Each task verified against ground truth (podman exec into the container), not just the chat/PTY surface.
Results: qwen2.5:3b vs qwen2.5-coder:7b
| Behaviour | qwen2.5:3b | qwen2.5-coder:7b |
|---|---|---|
Single command (whoami) |
PASS | PASS |
write+run (hello.sh date+hostname) |
PASS, accurate summary | PASS |
| Multi-step (mkdir→write→list) | FAIL — stalled after step 1 ("ok, let's proceed to the next step") | PASS — chained make_dir→write→read, completed |
| Recover from mid-task error | FAIL — gives up | INCONSISTENT — recovered from [unknown tool make_dir], but on greet.sh skipped chmod, hit exit 126, then stopped |
| Tool-schema discipline | clean | hallucinated a make_dir tool (not in schema) — wasted a turn ([unknown tool make_dir], bridge.py:597) |
| Final summary quality | vague ("I will proceed…") | empty → (done) fallback, or raw advice text |
| Latency (CPU, no GPU) | ~20–40 s/task | ~2–4× slower, 30–90 s/turn |
Failure modes observed (both sizes)
- Early termination on multi-step (3B dominant): the model emits filler text with no tool call mid-task; the loop reads "text + no tool call = done" and stops. The remaining steps never run.
- Give-up on unresolved non-zero exit (both sizes): after a failing command (exit 126/127), the model emits a summary/advice instead of fixing the cause. greet.sh left at mode 644 (never chmod'd) despite the task saying "make it executable".
- Tool hallucination (7B): invented
make_dir; the schema only has run_shell/write_file/read_file.
Root cause in code
_run_native, bridge.py:739–741:
if not calls:
final = (text or "").strip()
break # ANY text-without-toolcall ends the task
NATIVE_SYSTEM (line 111–113) also tells the model to signal completion this exact way. So one signal — "text, no tool call" — is overloaded to mean BOTH "done" and "stalling/thinking". Disambiguating it is the fix.
Takeaway: a bigger model buys multi-step persistence (the 3B's main flaw) but does NOT eliminate the give-up-on-error mode, and costs heavy latency. A nudge loop that keys off exit codes (not just filler text) earns its keep at both sizes.
Research: how Goose & opencode structure loop termination
(Source read directly from clones; key files cited.)
- Goose (
crates/goose/src/agents/agent.rs): tracksno_tools_called(line 1801). When true it does NOT just stop (lines 2232–2316) — in structured/goal modes it injects a continuation nudge (FINAL_OUTPUT_CONTINUATION_MESSAGE= "You MUST call the final_output tool NOW…") and loops. Completion is an explicit terminal tool (recipe__final_output,final_output_tool.rs). Vanilla chat with no recipe/goal does fall through to text-as-done, but every structured path overrides that. Bounded bymax_turns. - opencode (
packages/opencode/src/session/prompt.ts:1156–1183): exits only when finish is a real stop reason AND it independently re-derives that there are no pending tool calls from the parsed message parts — comment: "Some providers return 'stop' even when the assistant message contains tool calls." Hard step cap (maxSteps) with a wind-down message (MAX_STEPS,prompt/max-steps.txt); structured mode forcestoolChoice: "required". - Canonical / Cline-Roo: weak-model harnesses favour an explicit completion
action (
attempt_completion/submit) over trusting "empty tool_calls = done". - Recommendation from research: go structural, not filler-heuristic ("a losing
arms race"); nudge on text-without-completion; a hard cap is the only
unconditional exit; derive "did a tool get called" from parsed parts, not
finish_reason(qwen on CPU is unreliable there — it leaks tool calls as<tool_call>text incontent; already handled byOllamaProvider._extract_text_tool_calls).
Design: dynamic nudge loop (output-aware, structural terminator)
Structural termination via a DONE: text sentinel rather than a 4th tool.
Divergence from the research's "add a done tool", justified for THIS model:
qwen-on-CPU already mis-emits structured tool calls (leaks as <tool_call> text;
the 7B even hallucinated make_dir). A 4th tool invites the same malformation and
competes for attention; a DONE: prefix disambiguates the existing text channel at
zero schema cost. This is opencode's "require an explicit marker, don't trust the
implicit stop", applied to the text channel.
Changes in _run_native (bridge.py):
- NATIVE_SYSTEM (line 111–113): replace "reply with a summary and DO NOT call
a tool" with → "When and ONLY when the task is fully done, reply with one line
starting
DONE:and a one-sentence result. Otherwise you MUST call a tool." - Track loop state:
did_action(any tool ran),last_rc(parse theexit=already formatted by_run_shell_in_pty),nudges=0. - Replace the bare
break(739–741) with a verdict gate:- text starts with
DONE:→ done (fast path, no nudge) last_rc∉ {0, None} and noDONE:→ stalled (unresolved error)- no
did_action→ stalled (pure talk) - filler regex (
let's proceed,next step,i will, trailing colon) and noDONE:→ stalled - else (substantive text, action happened, no error) → accept as done — the single heuristic, on the SAFE side, so finished tasks aren't nudged every time (protects CPU latency, the cost a pure-structural form would incur here).
- text starts with
- On
stalled: append an output-aware, Goose-style nudge andcontinue, bounded byMAX_NUDGES = 2(separate from the productivemax_turnsso real multi-step work isn't starved):[if last_rc≠0:] "The last command exited {rc} (failure) — fix that first (e.g.
chmod +xbefore running a script)." + "You haven't signalled completion. If{task}is fully done replyDONE: …; otherwise call the next tool now — act, don't describe." - Wind-down: on the final turn, inject "reply
DONE:with your result now" (opencode'sMAX_STEPSpattern). - Keep
_extract_text_tool_calls(already present) — opencode's "derive tool calls from parsed parts, not finish_reason" lesson, which this model needs.
Fixes mapped to observed failures: 3B early-stall → nudged to continue; give-up on
error (both sizes) → nudged with the exit-code-aware message; over-nudging finished
tasks → avoided by the DONE: fast path + safe-side accept.
Live validation (qwen2.5:3b, post-implementation)
Ran the two prior failure cases against the freshly-built loop; ground truth via
podman exec hack-house.
- Multi-step (
mkdir proj3 → write notes.txt → list): PASS — fixed. Previously stalled after step 1; now chained write_file →ls -1 proj3to completion. Ground truth:proj3/notes.txtexists, contentshello world. The 3B's dominant failure mode is resolved by the loop alone (no model upgrade needed). - Nudge fires on non-zero exit: confirmed. On the
greet.shcase the PTY mirror showed▸ (nudge: finish the task or reply DONE:)after a 126, i.e. the output-aware re-prompt triggered structurally as designed. - Give-up-on-error is model-bound, not loop-bound. The 3B still can't recover
the greet.sh task even when nudged: across runs it wrote self-referential content
(
echo "Hello, world!" > greet.sh), itschmod +xdidn't stick (file left 644), and in one run it leaked a barewrite_file proj3/greet.sh …tool call as summary text (not the<tool_call>JSON form_extract_text_tool_callshandles). These are 3B capability limits, consistent with the 3B-vs-7B table — the loop's job is to detect and report them honestly, not to make a weak model competent.
Honesty hardening added after live test
The weak 3B routinely claims success it didn't achieve ("written, made executable, and run successfully" after a 126; "Created greet.sh… ran it" with nothing on disk). Echoing that prose as the final summary is actively misleading, so the nudge-budget exhaustion path no longer trusts it blindly:
- never ran a tool →
[stopped — model described the task but never ran a tool] - left a non-zero exit →
[stopped — last command exited {rc}; task likely incomplete] … - clean, action-backed turn → the model's summary (unchanged).
Offline unit coverage: 23 assertions on _completion_verdict / _parse_exit /
_strip_done / _nudge_message, all pass.